This is a chance to do a self-review of your changes before creating the PR are the changes too big (too many files, too many lines) to be easily and quickly reviewed? is the Pull Request doing too many different things? Can it be broken down into smaller PRs? did reading the code remind you of work you forgot to do? did you leave yourself ‘todo’ items that need to be completed? is every changed line necessary? Was anything accidentally committed? are there tests to cover the code changes / additions? are there documentation updates for the code changes / additions?
|